Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial stab at NavigationExperimental tutorial #8431

Closed
wants to merge 2 commits into from
Closed

Initial stab at NavigationExperimental tutorial #8431

wants to merge 2 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jun 25, 2016

Add a NavigationExperimental section to the Navigation guide.

navexp

@ghost
Copy link

ghost commented Jun 25, 2016

By analyzing the blame information on this pull request, we identified @caabernathy and @alvaromb to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 25, 2016
@hramos
Copy link
Contributor Author

hramos commented Jun 25, 2016

There's a few more content edits to go to get more of the Navigator and NavigatorIOS sections in sync with their API references. We may need to break out experimental into its own guide, but I don't want to have a new permalink for NavigationExperimental as the name has not been finalized yet.

@JoelMarcey
Copy link

Yay! This is great!

Looks like this needs a rebase.

Btw, did you try to add the React Native Web Player to any of your examples? Or is any navigation not supported by it?

@hramos
Copy link
Contributor Author

hramos commented Jun 27, 2016

@JoelMarcey That would be ideal, but I don't see any of the navigation APIs in react-native-web.

@JoelMarcey
Copy link

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 28, 2016
@ghost
Copy link

ghost commented Jun 28, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@JoelMarcey
Copy link

@hramos The patch is not applying internally. Might need another rebase -- we can try that. If that doesn't work, we may have to get more creative with an interactive rebase as the merge commit may have caused some possible funkiness here.

@ghost
Copy link

ghost commented Jun 29, 2016

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@ghost ghost added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jun 29, 2016
@hramos
Copy link
Contributor Author

hramos commented Jun 29, 2016

@facebook-github-bot shipit

@ghost ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jun 29, 2016
@hramos
Copy link
Contributor Author

hramos commented Jun 29, 2016

Rebased, lets see how it goes.

@ghost
Copy link

ghost commented Jun 29, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 3085b35 Jun 29, 2016
@JoelMarcey
Copy link

It shipped!

@JohnyDays
Copy link
Contributor

Thanks so much for this, I've been using it an app and winging it from examples, this is awesome!

bestander pushed a commit that referenced this pull request Jun 29, 2016
* Initial stab at NavigationExperimental tutorial

Summary:
Add a NavigationExperimental section to the Navigation guide.

![navexp](https://cloud.githubusercontent.com/assets/165856/16355280/120e7d38-3a67-11e6-9567-51c19c249fdf.png)
Closes #8431

Differential Revision: D3493158

Pulled By: JoelMarcey

fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e

* Change method name color for API/Component methods

Summary: Closes #8481

Differential Revision: D3497267

Pulled By: JoelMarcey

fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
Add a NavigationExperimental section to the Navigation guide.

![navexp](https://cloud.githubusercontent.com/assets/165856/16355280/120e7d38-3a67-11e6-9567-51c19c249fdf.png)
Closes facebook#8431

Differential Revision: D3493158

Pulled By: JoelMarcey

fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
Add a NavigationExperimental section to the Navigation guide.

![navexp](https://cloud.githubusercontent.com/assets/165856/16355280/120e7d38-3a67-11e6-9567-51c19c249fdf.png)
Closes facebook#8431

Differential Revision: D3493158

Pulled By: JoelMarcey

fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants